5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: zhong jiang <zhongjiang@xxxxxxxxxx> [ Upstream commit 8b063441b7417a79b0c27efc401479748ccf8ad1 ] st_tty_open do not need local variable to store different value, Hence just remove it. Signed-off-by: zhong jiang <zhongjiang@xxxxxxxxxx> Link: https://lore.kernel.org/r/1568307147-43468-1-git-send-email-zhongjiang@xxxxxxxxxx Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> Stable-dep-of: c83212d79be2 ("firmware: arm_sdei: Fix the input parameter of cpuhp_remove_state()") Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx> --- drivers/misc/ti-st/st_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/misc/ti-st/st_core.c b/drivers/misc/ti-st/st_core.c index c19460e7f0f16..7a7a1ac81ad02 100644 --- a/drivers/misc/ti-st/st_core.c +++ b/drivers/misc/ti-st/st_core.c @@ -709,7 +709,6 @@ EXPORT_SYMBOL_GPL(st_unregister); */ static int st_tty_open(struct tty_struct *tty) { - int err = 0; struct st_data_s *st_gdata; pr_info("%s ", __func__); @@ -732,7 +731,8 @@ static int st_tty_open(struct tty_struct *tty) */ st_kim_complete(st_gdata->kim_data); pr_debug("done %s", __func__); - return err; + + return 0; } static void st_tty_close(struct tty_struct *tty) -- 2.43.0
