On 03/11/2024 22:29, Andrey Konovalov wrote: > On Sun, Nov 3, 2024 at 3:28 AM Guilherme G. Piccoli <gpiccoli@xxxxxxxxxx> wrote: >> >> Hi folks, here is a series with some fixes for dummy_hcd. First of all, >> the reasoning behind it. >> >> Syzkaller report [0] shows a hung task on uevent_show, and despite it was >> fixed with a patch on drivers/base (a race between drivers shutdown and >> uevent_show), another issue remains: a problem with Realtek emulated wifi >> device [1]. While working the fix ([1]), we noticed that if it is >> applied to recent kernels, all fine. But in v6.1.y and v6.6.y for example, >> it didn't solve entirely the issue, and after some debugging, it was >> narrowed to dummy_hcd transfer rates being waaay slower in such stable >> versions. >> >> The reason of such slowness is well-described in the first 2 patches of >> this backport, but the thing is that these patches introduced subtle issues >> as well, fixed in the other 2 patches. Hence, I decided to backport all of >> them for the 2 latest LTS kernels. >> >> Maybe this is not a good idea - I don't see a strong con, but who's >> better to judge the benefits vs the risks than the patch authors, >> reviewers, and the USB maintainer?! So, I've CCed Alan, Andrey, Greg and >> Marcello here, and I thank you all in advance for reviews on this. And >> my apologies for bothering you with the emails, I hope this is a simple >> "OK, makes sense" or "Nah, doesn't worth it" situation =) > > Sounds good to me, thank you! > Thanks a bunch to all of you folks! For the reviews and the suggestion about the commit-ids. I've always sent patches to stable this way, be it a backport or even a cherry-pick, but it's interesting and definitely easier to just mention the IDs and ask for merge - thanks for the suggestion, I'll do that in case of future clean cherry-picks =) Cheers, Guilherme
