On Wed, Oct 30, 2024 at 09:36:32PM GMT, Rex Nie wrote:
> If the read of USB_PDPHY_RX_ACKNOWLEDGE_REG failed, then hdr_len and
> txbuf_len are uninitialized. This commit stops to print uninitialized
> value and misleading/false data.
>
> Cc: stable@xxxxxxxxxxxxxxx
> Fixes: a4422ff22142 (" usb: typec: qcom: Add Qualcomm PMIC Type-C driver")
> Signed-off-by: Rex Nie <rex.nie@xxxxxxxxxxxxxxx>
Reviewed-by: Bjorn Andersson <andersson@xxxxxxxxxx>
Nice job. Next time, please don't use In-Reply-To between patch
versions.
Regards,
Bjorn
> ---
> V2 -> V3:
> - add changelog, add Fixes tag, add Cc stable ml. Thanks heikki
> - Link to v2: https://lore.kernel.org/all/20241030022753.2045-1-rex.nie@xxxxxxxxxxxxxxx/
> V1 -> V2:
> - keep printout when data didn't transmit, thanks Bjorn, bod, greg k-h
> - Links: https://lore.kernel.org/all/b177e736-e640-47ed-9f1e-ee65971dfc9c@xxxxxxxxxx/
> ---
> drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy.c b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy.c
> index 5b7f52b74a40..726423684bae 100644
> --- a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy.c
> +++ b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy.c
> @@ -227,6 +227,10 @@ qcom_pmic_typec_pdphy_pd_transmit_payload(struct pmic_typec_pdphy *pmic_typec_pd
>
> spin_lock_irqsave(&pmic_typec_pdphy->lock, flags);
>
> + hdr_len = sizeof(msg->header);
> + txbuf_len = pd_header_cnt_le(msg->header) * 4;
> + txsize_len = hdr_len + txbuf_len - 1;
> +
> ret = regmap_read(pmic_typec_pdphy->regmap,
> pmic_typec_pdphy->base + USB_PDPHY_RX_ACKNOWLEDGE_REG,
> &val);
> @@ -244,10 +248,6 @@ qcom_pmic_typec_pdphy_pd_transmit_payload(struct pmic_typec_pdphy *pmic_typec_pd
> if (ret)
> goto done;
>
> - hdr_len = sizeof(msg->header);
> - txbuf_len = pd_header_cnt_le(msg->header) * 4;
> - txsize_len = hdr_len + txbuf_len - 1;
> -
> /* Write message header sizeof(u16) to USB_PDPHY_TX_BUFFER_HDR_REG */
> ret = regmap_bulk_write(pmic_typec_pdphy->regmap,
> pmic_typec_pdphy->base + USB_PDPHY_TX_BUFFER_HDR_REG,
> --
> 2.17.1
>
>
