On 30/10/2024 23:15, Ping-Ke Shih wrote: > >> diff --git a/drivers/net/wireless/realtek/rtlwifi/efuse.c b/drivers/net/wireless/realtek/rtlwifi/efuse.c >> index 82cf5fb5175f..f741066c06de 100644 >> --- a/drivers/net/wireless/realtek/rtlwifi/efuse.c >> +++ b/drivers/net/wireless/realtek/rtlwifi/efuse.c >> @@ -164,7 +164,17 @@ void read_efuse_byte(struct ieee80211_hw *hw, u16 _offset, u8 *pbuf) >> struct rtl_priv *rtlpriv = rtl_priv(hw); >> u32 value32; >> u8 readbyte; >> - u16 retry; >> + u16 retry, max_attempts; >> + > > Declarations should be in reverse X'mas tree order. > Just add max_attempts to a new line at proper position. Thanks, V3 just sent: https://lore.kernel.org/r/20241031155731.1253259-1-gpiccoli@xxxxxxxxxx/