On 31/10/2024 15:18, Kalle Valo wrote: > Javier Carrasco <javier.carrasco.cruz@xxxxxxxxx> wrote: > >> The fixed patch introduced an additional condition to enter the scope >> where the 'root' device_node is released (!settings->board_type, >> currently 'err'), which avoid decrementing the refcount with a call to >> of_node_put() if that second condition is not satisfied. >> >> Move the call to of_node_put() to the point where 'root' is no longer >> required to avoid leaking the resource if err is not zero. >> >> Cc: stable@xxxxxxxxxxxxxxx >> Fixes: 7682de8b3351 ("wifi: brcmfmac: of: Fetch Apple properties") >> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@xxxxxxxxx> > > Wireless patches go to wireless trees, not net. But no need to resend because > of this. And I think wireless-next is approriate for this fix. > Sorry, the second link from your signature explains very well what I should have done. I will keep that in mind for the next patch(es) to wireless. Thank you and best regards, Javier Carrasco