On Wed, Oct 30, 2024 at 06:32:57PM +0800, Rex Nie wrote: > If the read of USB_PDPHY_RX_ACKNOWLEDGE_REG failed, then hdr_len and > txbuf_len are uninitialized. This commit stops to print uninitialized > value and misleading/false data. > > --- > V2 -> V3: > - add changelog, add Fixes tag, add Cc stable ml. Thanks heikki > - Link to v2: https://lore.kernel.org/all/20241030022753.2045-1-rex.nie@xxxxxxxxxxxxxxx/ > V1 -> V2: > - keep printout when data didn't transmit, thanks Bjorn, bod, greg k-h > - Links: https://lore.kernel.org/all/b177e736-e640-47ed-9f1e-ee65971dfc9c@xxxxxxxxxx/ > > Cc: stable@xxxxxxxxxxxxxxx > Fixes: a4422ff22142 (" usb: typec: qcom: Add Qualcomm PMIC Type-C driver") > Signed-off-by: Rex Nie <rex.nie@xxxxxxxxxxxxxxx> Sorry, but this is still broken. Those tags need to come before the "---". Otherwise they will not end-up into the actual commit when this patch is applied. It should look something like this: usb: typec: qcom-pmic: init value of hdr_len/txbuf_len earlier If the read of USB_PDPHY_RX_ACKNOWLEDGE_REG failed, then hdr_len and txbuf_len are uninitialized. This commit stops to print uninitialized value and misleading/false data. Cc: stable@xxxxxxxxxxxxxxx Fixes: a4422ff22142 (" usb: typec: qcom: Add Qualcomm PMIC Type-C driver") Signed-off-by: Rex Nie <rex.nie@xxxxxxxxxxxxxxx> --- V2 -> V3: - add changelog, add Fixes tag, add Cc stable ml. Thanks heikki - Link to v2: https://lore.kernel.org/all/20241030022753.2045-1-rex.nie@xxxxxxxxxxxxxxx/ V1 -> V2: - keep printout when data didn't transmit, thanks Bjorn, bod, greg k-h - Links: https://lore.kernel.org/all/b177e736-e640-47ed-9f1e-ee65971dfc9c@xxxxxxxxxx/ drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/usb/typec... thanks, -- heikki