On Wed, Oct 30, 2024 at 07:38:32AM +0100, Javier Carrasco wrote: > If of_find_device_by_node() fails, its error path does not include a > call to of_node_put(cpu_node), which has been successfully acquired at > this point. > > Move the existing of_node_put(cpu_node) to the point where cpu_node is > no longer required, covering all code paths and avoiding leaking the > resource in any case. > > Cc: stable@xxxxxxxxxxxxxxx > Fixes: 60f3692b5f0b ("cpuidle: qcom_spm: Detach state machine from main SPM handling") > Signed-off-by: Javier Carrasco <javier.carrasco.cruz@xxxxxxxxx> > --- > drivers/cpuidle/cpuidle-qcom-spm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> -- With best wishes Dmitry