Thanks Linus for taking care of this! On 10/28/24 11:44 AM, Linus Walleij wrote: > From: Michael Walle <mwalle@xxxxxxxxxx> > nit: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html says we *must* note the upstream commit ID with a separate line above the commit text like this: ```commit <sha1> upstream.``` or alternatively: ```[ Upstream commit <sha1> ]``` With this addressed: Reviewed-by: Tudor Ambarus <tudor.ambarus@xxxxxxxxxx> > Commit 83e824a4a595 ("mtd: spi-nor: Correct flags for Winbond w25q128") > removed the flags for non-SFDP devices. It was assumed that it wasn't in > use anymore. This wasn't true. Add the no_sfdp_flags as well as the size > again. > > We add the additional flags for dual and quad read because they have > been reported to work properly by Hartmut using both older and newer > versions of this flash, the similar flashes with 64Mbit and 256Mbit > already have these flags and because it will (luckily) trigger our > legacy SFDP parsing, so newer versions with SFDP support will still get > the parameters from the SFDP tables. > > This was applied to mainline as > commit e49b2731c396 ("mtd: spi-nor: winbond: fix w25q128 regression") invalid sha1, it must have been: d35df77707bf5ae1221b5ba1c8a88cf4fcdd4901 Cheers, ta
