On Mon, 2024-10-28 at 12:28 -0700, Saravana Kannan wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>
>
> On Sun, Oct 27, 2024 at 11:33 PM Jason-JH.Lin via B4 Relay
> <devnull+jason-jh.lin.mediatek.com@xxxxxxxxxx> wrote:
> >
> > From: "Jason-JH.Lin" <jason-jh.lin@xxxxxxxxxxxx>
> >
> > This reverts commit ac88a1f41f93499df6f50fd18ea835e6ff4f3200.
> >
> > Reason for revert:
> > 1. The commit [1] does not land on linux-5.15, so this patch does
> > not
> > fix anything.
> >
> > 2. Since the fw_device improvements series [2] does not land on
>
> fw_devlink. Not fw_device.
>
OK, I'll fix this in v4.
Regards,
Jason-JH.Lin
> -Saravana
>
> > linux-5.15, using device_set_fwnode() causes the panel to flash
> > during
> > bootup.
> >
> > Incorrect link management may lead to incorrect device
> > initialization,
> > affecting firmware node links and consumer relationships.
> > The fwnode setting of panel to the DSI device would cause a DSI
> > initialization error without series[2], so this patch was reverted
> > to
> > avoid using the incomplete fw_devlink functionality.
> >
> > [1] commit 3fb16866b51d ("driver core: fw_devlink: Make cycle
> > detection more robust")
> > [2] Link:
> > https://lore.kernel.org/all/20230207014207.1678715-1-saravanak@xxxxxxxxxx
> >
> > Cc: stable@xxxxxxxxxxxxxxx # 5.15.169
> > Cc: stable@xxxxxxxxxxxxxxx # 5.10.228
> > Cc: stable@xxxxxxxxxxxxxxx # 5.4.284
> > Signed-off-by: Jason-JH.Lin <jason-jh.lin@xxxxxxxxxxxx>
> > ---
> > drivers/gpu/drm/drm_mipi_dsi.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/drm_mipi_dsi.c
> > b/drivers/gpu/drm/drm_mipi_dsi.c
> > index 24606b632009..468a3a7cb6a5 100644
> > --- a/drivers/gpu/drm/drm_mipi_dsi.c
> > +++ b/drivers/gpu/drm/drm_mipi_dsi.c
> > @@ -221,7 +221,7 @@ mipi_dsi_device_register_full(struct
> > mipi_dsi_host *host,
> > return dsi;
> > }
> >
> > - device_set_node(&dsi->dev, of_fwnode_handle(info->node));
> > + dsi->dev.of_node = info->node;
> > dsi->channel = info->channel;
> > strlcpy(dsi->name, info->type, sizeof(dsi->name));
> >
> >
> > ---
> > base-commit: 74cdd62cb4706515b454ce5bacb73b566c1d1bcf
> > change-id: 20241024-fixup-5-15-5fdd68dae707
> >
> > Best regards,
> > --
> > Jason-JH.Lin <jason-jh.lin@xxxxxxxxxxxx>
> >
> >
