On 28/10/2024 13:26, Javier Carrasco wrote: [ ... ]
Hi Daniel, thanks for your feedback. Actually, if we are going to refactor the code, we would not need the extra variable or even the call to of_node_put(), since we could use the __free() macro. That would be a second patch after the fix, which could stay as it is without refactoring, because it is only to backport the missing calls to of_node_put(). I can send a v2 with the extra patch leaving this one as it is, or if really desired, with the available variable.
V2 with __free is fine -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog