On Wed, 2024-10-23 at 19:52 -0700, Andrew Morton wrote: > > The patch titled > Subject: lib: string_helpers: fix potential snprintf() output > truncation > has been added to the -mm mm-hotfixes-unstable branch. Its filename > is > lib-string_helpers-fix-potential-snprintf-output- > truncation.patch > > This patch will shortly appear at > > https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/lib-string_helpers-fix-potential-snprintf-output-truncation.patch > > This patch will later appear in the mm-hotfixes-unstable branch at > git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm > > Before you just go and hit "reply", please: > a) Consider who else should be cc'ed > b) Prefer to cc a suitable mailing list as well > c) Ideally: find the original patch on the mailing list and do a > reply-to-all to that, adding suitable additional cc's > > *** Remember to use Documentation/process/submit-checklist.rst when > testing your code *** > > The -mm tree is included into linux-next via the mm-everything > branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm > and is updated there every 2-3 working days > > ------------------------------------------------------ > From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx> > Subject: lib: string_helpers: fix potential snprintf() output > truncation > Date: Mon, 21 Oct 2024 11:14:17 +0200 > > The output of ".%03u" with the unsigned int in range [0, 4294966295] > may get truncated if the target buffer is not 12 bytes. I think we all agree the explanation isn't accurate: remainder will be between 0-999 (not range [0, 4294966295]) which means that the string will only ever be 5 bytes (including leading zero). This might be required to correct a compiler false warning, but if it is applied, the patch description should say this. James
