On Mon, Oct 21, 2024 at 5:53 PM Brian Geffon <bgeffon@xxxxxxxxxx> wrote:
>
> On Tue, Oct 15, 2024 at 8:48 AM Greg Kroah-Hartman
> <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> >
> > On Tue, Oct 15, 2024 at 03:31:57PM +0300, Alexander Usyskin wrote:
> > > Read buffer is allocated according to max message size, reported by
> > > the firmware and may reach 64K in systems with pxp client.
> > > Contiguous 64k allocation may fail under memory pressure.
> > > Read buffer is used as in-driver message storage and not required
> > > to be contiguous.
> > > Use kvmalloc to allow kernel to allocate non-contiguous memory.
> > >
> > > Fixes: 3030dc056459 ("mei: add wrapper for queuing control commands.")
> > > Reported-by: Rohit Agarwal <rohiagar@xxxxxxxxxxxx>
> > > Closes: https://lore.kernel.org/all/20240813084542.2921300-1-rohiagar@xxxxxxxxxxxx/
> > > Tested-by: Brian Geffon <bgeffon@xxxxxxxxxx>
> > > Signed-off-by: Alexander Usyskin <alexander.usyskin@xxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx
>
> > > ---
> >
> > Why is this on the -next branch? You want this merged now, right?
> >
> > Again, I asked "why hasn't this been reviewed by others at Intel", and
> > so I'm just going to delete this series until it has followed the
> > correct Intel-internal review process.
>
> This is a significant crash for us, any chance we can get another
> reviewer from Intel?
>
>
> reviewer from Intel?
(second attempt, forgot to remove html formatting)
I'm no longer with Intel but I'm aware of this fix, so as the former
driver maintainer:
Acked-by: Tomas Winkler <tomasw@xxxxxxxxx>
