On Wed, Oct 16, 2024 at 09:07:39AM +0000, Puranjay Mohan wrote: > [ Upstream commit 7c2fd76048e95dd267055b5f5e0a48e6e7c81fd9 ] > > On an NVMe namespace that does not support metadata, it is possible to > send an IO command with metadata through io-passthru. This allows issues > like [1] to trigger in the completion code path. > nvme_map_user_request() doesn't check if the namespace supports metadata > before sending it forward. It also allows admin commands with metadata to > be processed as it ignores metadata when bdev == NULL and may report > success. > > Reject an IO command with metadata when the NVMe namespace doesn't > support it and reject an admin command if it has metadata. > > [1] https://lore.kernel.org/all/mb61pcylvnym8.fsf@xxxxxxxxxx/ > > Suggested-by: Christoph Hellwig <hch@xxxxxx> > Reviewed-by: Christoph Hellwig <hch@xxxxxx> > Reviewed-by: Sagi Grimberg <sagi@xxxxxxxxxxx> > Reviewed-by: Anuj Gupta <anuj20.g@xxxxxxxxxxx> > Signed-off-by: Keith Busch <kbusch@xxxxxxxxxx> > [ Minor changes to make it work on 6.1 ] What about 6.6? And 5.15? We can't take patches for only some branches, otherwise when you upgrade you would have regressions. Please send ALL needed patches and then we will be glad to queue them up. I've dropped the two submissions you sent for now. thanks, greg k-h
