On Wed, 2024-10-16 at 12:08 +0300, Andy Shevchenko wrote: > On Wed, Oct 16, 2024 at 09:25:54AM +0200, Philipp Stanner wrote: > > In psnet_open_pf_bar() and snet_open_vf_bar() a string later passed > > to > > pcim_iomap_regions() is placed on the stack. Neither > > pcim_iomap_regions() nor the functions it calls copy that string. > > > > Should the string later ever be used, this, consequently, causes > > undefined behavior since the stack frame will by then have > > disappeared. > > > > Fix the bug by allocating the strings on the heap through > > devm_kasprintf(). > > > --- > > I haven't found the reason for resending. Can you elaborate here? Impatience ;p This is not a v2. I mean, it's a bug, easy to fix and merge [and it's blocking my other PCI work, *cough*]. Should contributors wait longer than 8 days until resending in your opinion? P.
