Re: [PATCH] drm/radeon: don't init gpuvm if accel is disabled

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 29.01.2015 um 08:46 schrieb Oded Gabbay:


On 01/28/2015 09:41 PM, Alex Deucher wrote:
If acceleration is disabled, it does not make sense
to init gpuvm since nothing will use it.  Moreover,
if radeon_vm_init() gets called it uses accel to try
and clear the pde tables, etc. which results in a bug.

Bug:
https://bugs.freedesktop.org/show_bug.cgi?id=88786

Signed-off-by: Alex Deucher<alexander.deucher@xxxxxxx>
Cc:stable@xxxxxxxxxxxxxxx

Patch is Reviewed-by: Christian König <christian.koenig@xxxxxxx>

Alex,
What is accel ?
Is there a situation where accel is disabled and HSA should work ? e.g. headless mode ?

Not really.

Acceleration is disabled mostly because the user forgotten to install the firmware or we have a rather big bug in the driver and can't get the CP running.

In that case we still try to provide mode setting to get an error message on the screen, but everything else won't work.

Regards,
Christian.



If so, we need gpuvm for local memory.

    Oded
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel

--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]