Hello,
On 10/14/2024 3:01 PM, Greg KH wrote:
> On Mon, Oct 14, 2024 at 10:50:23AM +0530, Dhananjay Ugwekar wrote:
>> Hello,
>>
>> This patch is only needed post the commit cpufreq: amd-pstate: Unify computation of {max,min,nominal,lowest_nonlinear}_freq. Hence, please do not add it to the 6.6 stable tree.
>
> Then the tag:
>
>>
>> Thanks,
>> Dhananjay
>>
>>
>> On 10/11/2024 5:48 AM, Sasha Levin wrote:
>>> This is a note to let you know that I've just added the patch titled
>>>
>>> cpufreq/amd-pstate-ut: Convert nominal_freq to khz during comparisons
>>>
>>> to the 6.6-stable tree which can be found at:
>>> http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
>>>
>>> The filename of the patch is:
>>> cpufreq-amd-pstate-ut-convert-nominal_freq-to-khz-du.patch
>>> and it can be found in the queue-6.6 subdirectory.
>>>
>>> If you, or anyone else, feels it should not be added to the stable tree,
>>> please let <stable@xxxxxxxxxxxxxxx> know about it.
>>>
>>>
>>>
>>> commit 09778adee7fa70b5efeaefd17a6e0a0b9d7de62e
>>> Author: Dhananjay Ugwekar <Dhananjay.Ugwekar@xxxxxxx>
>>> Date: Tue Jul 2 08:14:13 2024 +0000
>>>
>>> cpufreq/amd-pstate-ut: Convert nominal_freq to khz during comparisons
>>>
>>> [ Upstream commit f21ab5ed4e8758b06230900f44b9dcbcfdc0c3ae ]
>>>
>>> cpudata->nominal_freq being in MHz whereas other frequencies being in
>>> KHz breaks the amd-pstate-ut frequency sanity check. This fixes it.
>>>
>>> Fixes: e4731baaf294 ("cpufreq: amd-pstate: Fix the inconsistency in max frequency units")
>
> Is wrong?
Actually this tag is correct, but the tag for commit "e4731baaf294 ("cpufreq: amd-pstate: Fix the inconsistency in max frequency units")"
was incorrect(i.e. Fixes: ec437d7 ("cpufreq: amd-pstate: Introduce a new AMD P-State driver to support future processors")), it should've
been "Fixes: 5547c0ebfc2e ("cpufreq: amd-pstate: Unify computation of {max,min,nominal,lowest_nonlinear}_freq")" instead.
Sorry about the confusion.
>
> If so, that's fine, but note that this is why this was added to the
> tree.
>
> I'll go drop these from the queue now.
Thanks!
Regards,
Dhananjay
>
> thanks,
>
> greg k-h
