On 10/11/2024 3:25 PM, Nirmoy Das wrote:
> do_comapre() can return success after wait_woken() which is treated as
> -ETIME here.
s/after wait_woken()/after timedout wait_woken()
I will resend with that change.
>
> Fixes: e670f0b4ef24 ("drm/xe/uapi: Return correct error code for xe_wait_user_fence_ioctl")
> Cc: <stable@xxxxxxxxxxxxxxx> # v6.8+
> Cc: Bommu Krishnaiah <krishnaiah.bommu@xxxxxxxxx>
> Link: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/1630
> Cc: Matthew Auld <matthew.auld@xxxxxxxxx>
> Cc: Matthew Brost <matthew.brost@xxxxxxxxx>
> Signed-off-by: Nirmoy Das <nirmoy.das@xxxxxxxxx>
> ---
> drivers/gpu/drm/xe/xe_wait_user_fence.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_wait_user_fence.c b/drivers/gpu/drm/xe/xe_wait_user_fence.c
> index d46fa8374980..d532283d4aa3 100644
> --- a/drivers/gpu/drm/xe/xe_wait_user_fence.c
> +++ b/drivers/gpu/drm/xe/xe_wait_user_fence.c
> @@ -169,7 +169,7 @@ int xe_wait_user_fence_ioctl(struct drm_device *dev, void *data,
> args->timeout = 0;
> }
>
> - if (!timeout && !(err < 0))
> + if (!timeout && err < 0)
> err = -ETIME;
>
> if (q)
