Re: [PATCH v2] HID: wacom: Hardcode (non-inverted) AES pens as BTN_TOOL_PEN

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 9 Oct 2024, Gerecke, Jason wrote:

> From: Jason Gerecke <jason.gerecke@xxxxxxxxx>
> 
> Unlike EMR tools which encode type information in their tool ID, tools
> for AES sensors are all "generic pens". It is inappropriate to make use
> of the wacom_intuos_get_tool_type function when dealing with these kinds
> of devices. Instead, we should only ever report BTN_TOOL_PEN or
> BTN_TOOL_RUBBER, as depending on the state of the Eraser and Invert
> bits.
> 
> Reported-by: Daniel Jutz <daniel@xxxxxxxxx>
> Closes: https://lore.kernel.org/linux-input/3cd82004-c5b8-4f2a-9a3b-d88d855c65e4@xxxxxxxxx/
> Bisected-by: Christian Heusel <christian@xxxxxxxxx>
> Fixes: 9c2913b962da ("HID: wacom: more appropriate tool type categorization")
> Link: https://gitlab.freedesktop.org/libinput/libinput/-/issues/1041
> Link: https://github.com/linuxwacom/input-wacom/issues/440
> Signed-off-by: Jason Gerecke <jason.gerecke@xxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx
> Acked-by: Benjamin Tissoires <bentiss@xxxxxxxxxx>

Applied, thanks Jason.

-- 
Jiri Kosina
SUSE Labs





[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux