On Wed, 9 Oct 2024 15:36:42 +0200
Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> On Tue, Oct 08, 2024 at 03:29:44PM -0700, Sherry Yang wrote:
> > 5.10.y backported the commit
> > 09bcf9254838 ("selftests/ftrace: Add new test case which checks non unique symbol")
> > which added a new test case to check non-unique symbol. However, 5.10.y
> > didn't backport the kernel commit
> > b022f0c7e404 ("tracing/kprobes: Return EADDRNOTAVAIL when func matches several symbols")to support the functionality from kernel side. Backport it in this patch series.
> >
> > The first two patches are presiquisites. The 4th commit is a fix commit
> > for the 3rd one.
>
> Should we just revert the selftest test instead? That seems simpler
> instead of adding a new feature to this old and obsolete kernel tree,
> right?
The selftest is just testing to see if the kernel has the bug. The bug is
that if there's more than one function with the same name, and someone
attaches a kprobe to one of them, the user doesn't know which function it
is attaching to, and the kernel doesn't tell the user that it's picking
some random function. This can have undesirable results.
I don't know how much this kernel is still used. But if it's supported and
still taking fixes, I would consider this a fix and not a feature.
-- Steve
