Re: [PATCH 2/2] drm/vc4: Stop the active perfmon before being destroyed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/4/24 09:36, Maíra Canal wrote:
Upon closing the file descriptor, the active performance monitor is not
stopped. Although all perfmons are destroyed in `vc4_perfmon_close_file()`,
the active performance monitor's pointer (`vc4->active_perfmon`) is still
retained.

If we open a new file descriptor and submit a few jobs with performance
monitors, the driver will attempt to stop the active performance monitor
using the stale pointer in `vc4->active_perfmon`. However, this pointer
is no longer valid because the previous process has already terminated,
and all performance monitors associated with it have been destroyed and
freed.

To fix this, when the active performance monitor belongs to a given
process, explicitly stop it before destroying and freeing it.

Cc: <stable@xxxxxxxxxxxxxxx> # v4.17+
Cc: Boris Brezillon <bbrezillon@xxxxxxxxxx>
Cc: Juan A. Suarez Romero <jasuarez@xxxxxxxxxx>
Fixes: 65101d8c9108 ("drm/vc4: Expose performance counters to userspace")
Signed-off-by: Maíra Canal <mcanal@xxxxxxxxxx>
---
  drivers/gpu/drm/vc4/vc4_perfmon.c | 7 ++++++-
  1 file changed, 6 insertions(+), 1 deletion(-)


Applied to misc/kernel.git (drm-misc-fixes).

Best Regards,
- Maíra




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux