On Tue, Oct 01, 2024 at 03:00:05AM -0700, Dmitry Torokhov wrote: > On Tue, Oct 01, 2024 at 11:32:16AM +0200, Greg KH wrote: > > On Tue, Oct 01, 2024 at 02:08:42AM -0700, Dmitry Torokhov wrote: > > > On Mon, Sep 30, 2024 at 08:28:59PM -0400, Sasha Levin wrote: > > > > This is a note to let you know that I've just added the patch titled > > > > > > > > Input: ps2-gpio - use IRQF_NO_AUTOEN flag in request_irq() > > > > > > > > to the 5.15-stable tree which can be found at: > > > > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary > > > > > > > > The filename of the patch is: > > > > input-ps2-gpio-use-irqf_no_autoen-flag-in-request_ir.patch > > > > and it can be found in the queue-5.15 subdirectory. > > > > > > > > If you, or anyone else, feels it should not be added to the stable tree, > > > > please let <stable@xxxxxxxxxxxxxxx> know about it. > > > > > > For the love of God, why? Why does this pure cleanup type of change > > > needs to be in stable? > > > > Because someone said: > > > > > > commit 2d007ddec282076923c4d84d6b12858b9f44594a > > > > Author: Jinjie Ruan <ruanjinjie@xxxxxxxxxx> > > > > Date: Thu Sep 12 11:30:13 2024 +0800 > > > > > > > > Input: ps2-gpio - use IRQF_NO_AUTOEN flag in request_irq() > > > > > > > > [ Upstream commit dcd18a3fb1228409dfc24373c5c6868a655810b0 ] > > > > > > > > disable_irq() after request_irq() still has a time gap in which > > > > interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will > > > > disable IRQ auto-enable when request IRQ. > > > > Looks like a bug fix, and also: > > > > > > Fixes: 9ee0a0558819 ("Input: PS/2 gpio bit banging driver for serio bus") > > > > Someone marked it as such. > > > > I'll go drop it, but really, don't mark things as fixes if they really > > are not. > > They are fixes, they just do not belong to stable and that is why they > are not marked as such. Ok, if your subsystem will always mark this type of thing properly, we will be glad to add you to the "don't take any Fixes: only commits" to the list that we keep. Here's the subsystems that we currently do this for: https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/tree/ignore_list what regex should we use for this list? thanks, greg k-h