Re: [PATCH 6.6.y] bnxt_en: Cap the size of HWRM_PORT_PHY_QCFG forwarded response

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 16, 2024 at 10:31:02AM -0700, Samasth Norway Ananda wrote:
> From: Michael Chan <michael.chan@xxxxxxxxxxxx>
> 
> commit 7d9df38c9c037ab84502ce7eeae9f1e1e7e72603 upstream.
> 
> Firmware interface 1.10.2.118 has increased the size of
> HWRM_PORT_PHY_QCFG response beyond the maximum size that can be
> forwarded.  When the VF's link state is not the default auto state,
> the PF will need to forward the response back to the VF to indicate
> the forced state.  This regression may cause the VF to fail to
> initialize.
> 
> Fix it by capping the HWRM_PORT_PHY_QCFG response to the maximum
> 96 bytes.  The SPEEDS2_SUPPORTED flag needs to be cleared because the
> new speeds2 fields are beyond the legacy structure.  Also modify
> bnxt_hwrm_fwd_resp() to print a warning if the message size exceeds 96
> bytes to make this failure more obvious.
> 
> Fixes: 84a911db8305 ("bnxt_en: Update firmware interface to 1.10.2.118")
> Reviewed-by: Somnath Kotur <somnath.kotur@xxxxxxxxxxxx>
> Reviewed-by: Pavan Chebbi <pavan.chebbi@xxxxxxxxxxxx>
> Signed-off-by: Michael Chan <michael.chan@xxxxxxxxxxxx>
> Link: https://lore.kernel.org/r/20240612231736.57823-1-michael.chan@xxxxxxxxxxxx
> Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx>
> [Samasth: backport to 6.6.y]
> Signed-off-by: Samasth Norway Ananda <samasth.norway.ananda@xxxxxxxxxx>
> ---
>  drivers/net/ethernet/broadcom/bnxt/bnxt.h     | 51 +++++++++++++++++++
>  .../net/ethernet/broadcom/bnxt/bnxt_sriov.c   | 12 ++++-
>  2 files changed, 61 insertions(+), 2 deletions(-)
> 

This breaks the build :(




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux