On Sun, Sep 15, 2024 at 4:41 PM Alice Ryhl <aliceryhl@xxxxxxxxxx> wrote: > > The `LockedBy::access` method only requires a shared reference to the > owner, so if we have shared access to the `LockedBy` from several > threads at once, then two threads could call `access` in parallel and > both obtain a shared reference to the inner value. Thus, require that > `T: Sync` when calling the `access` method. > > An alternative is to require `T: Sync` in the `impl Sync for LockedBy`. > This patch does not choose that approach as it gives up the ability to > use `LockedBy` with `!Sync` types, which is okay as long as you only use > `access_mut`. > > Cc: stable@xxxxxxxxxxxxxxx > Fixes: 7b1f55e3a984 ("rust: sync: introduce `LockedBy`") > Signed-off-by: Alice Ryhl <aliceryhl@xxxxxxxxxx> Applied to `rust-fixes` with Boqun's Suggested-by -- thanks! Cheers, Miguel