On Thu, Sep 19, 2024 at 11:04:23AM +0200, Greg KH wrote: > On Thu, Sep 19, 2024 at 08:38:52AM +0000, Wan, Qin (Thin Client RnD) wrote: > > Hello, > > > > There is an issue found on v6.6.16: Plug in thunderbolt G4 dock with monitor connected after system boots up. The monitor shows nothing when wake up from S3 sometimes. The failure rate is above 50%. > > The kernel reports “UBSAN: shift-out-of-bounds in drivers/gpu/drm/display/drm_dp_mst_topology.c:4416:36”. The call stack is shown at the bottom of this email. > > This failure is fixed in v6.9-rc1. > > We request to merge below commit to v6.6. > > > > 6b8ac54f31f985d3abb0b4212187838dd8ea4227 > > thunderbolt: Fix debug log when DisplayPort adapter not available for pairing > > > > fe8a0293c922ee8bc1ff0cf9048075afb264004a > > thunderbolt: Use tb_tunnel_dbg() where possible to make logging more consistent > > > > d27bd2c37d4666bce25ec4d9ac8c6b169992f0f0 > > thunderbolt: Expose tb_tunnel_xxx() log macros to the rest of the driver > > > > 8648c6465c025c488e2855c209c0dea1a1a15184 > > thunderbolt: Create multiple DisplayPort tunnels if there are more DP IN/OUT pairs > > > > f73edddfa2a64a185c65a33f100778169c92fc25 > > thunderbolt: Use constants for path weight and priority > > > > 4d24db0c801461adeefd7e0bdc98c79c60ccefb0 > > thunderbolt: Use weight constants in tb_usb3_consumed_bandwidth() > > > > aa673d606078da36ebc379f041c794228ac08cb5 > > thunderbolt: Make is_gen4_link() available to the rest of the driver > > > > 582e70b0d3a412d15389a3c9c07a44791b311715 > > thunderbolt: Change bandwidth reservations to comply USB4 v2 > > > > 2bfeca73e94567c1a117ca45d2e8a25d63e5bd2c > > thunderbolt: Introduce tb_port_path_direction_downstream() > > > > 956c3abe72fb6a651b8cf77c28462f7e5b6a48b1 > > thunderbolt: Introduce tb_for_each_upstream_port_on_path() > > > > c4ff14436952c3d0dd05769d76cf48e73a253b48 > > thunderbolt: Introduce tb_switch_depth() > > > > 81af2952e60603d12415e1a6fd200f8073a2ad8b > > thunderbolt: Add support for asymmetric link > > > > 3e36528c1127b20492ffaea53930bcc3df46a718 > > thunderbolt: Configure asymmetric link if needed and bandwidth allows > > > > b4734507ac55cc7ea1380e20e83f60fcd7031955 > > thunderbolt: Improve DisplayPort tunnel setup process to be more robust > > Can you send these as a backported series with your signed-off-by to > show that you have tested these to verify that they work properly in the > 6.6 kernel tree? That will make them much easier to apply, and track > over time. > We used the below command to apply the patches. Is this helpful, or is resubmitting the series still required? If so, what script do you use to add the "upstream commit" lines to the commit message? git cherry-pick 6b8ac54f31f9 fe8a0293c922 d27bd2c37d46 8648c6465c02 \ f73edddfa2a6 4d24db0c8014 aa673d606078 582e70b0d3a4 \ 2bfeca73e945 956c3abe72fb c4ff14436952 81af2952e606 \ 3e36528c1127 b4734507ac55 It's commit 709f7c7172ae ("thunderbolt: Improve DisplayPort tunnel setup process to be more robust") which solves the issue, and the pthers are dependencies. > Also, you should cc: the relevant maintainers/developers of those > changes to allow them to comment if they should be backported or not. > > thanks, > > greg k-h >