Bcc:
Subject: Re: [PATCH] zram: don't free statically defined names
Reply-To:
In-Reply-To: <20240923153449.GC38742@xxxxxxxxxx>
Cc-ing Venkat Rao Bagalkote
On (24/09/24 00:34), Sergey Senozhatsky wrote:
> > for (prio = ZRAM_SECONDARY_COMP; prio < ZRAM_MAX_COMPS; prio++) {
> > - kfree(zram->comp_algs[prio]);
> > + /* Do not free statically defined compression algorithms */
>
> We probably don't really need this comment.
>
> > + if (zram->comp_algs[prio] != default_compressor)
> > + kfree(zram->comp_algs[prio]);
> > zram->comp_algs[prio] = NULL;
> > }
>
> OK, so... I wonder how do you get a `default_compressor` on a
> non-ZRAM_PRIMARY_COMP prio. May I ask what's your reproducer?
>
> I didn't expect `default_compressor` on ZRAM_SECONDARY_COMP
> and below. As far as I can tell, we only do this:
>
> comp_algorithm_set(zram, ZRAM_PRIMARY_COMP, default_compressor);
>
> in zram_reset_device() and zram_add(). So, how does it end up in
> ZRAM_SECONDARY_COMP...
Ugh, I know what's happening. You don't have CONFIG_ZRAM_MULTI_COMP
so that ZRAM_PRIMARY_COMP and ZRAM_SECONDARY_COMP are the same thing.
Yeah, that all makes sense now, I haven't thought about it.
Can you please send v2 (with the feedback resolved).
