On 9/12/24 6:49 AM, Peter Wang (王信友) wrote:
On Wed, 2024-09-11 at 12:37 -0700, Bart Van Assche wrote:
[ ... ]
So at this time, the device will not have a corresponding
response coming back. The host controller will automatically
fill in the response for the corresponding command based on
the results of SQ cleanup (MCQ) or UTRLCLR (DBR, mediatek),
with the COS content being ABORTED by interrupt.
I don't think so. In SDB mode, writing into the UTRLCLR register does
NOT cause the ABORTED status to be written into the OCS field. Even if
there would be UFSHCI controllers that do this, the UFSHCI specification
does not require this behavior and hence the UFS driver should not
assume this behavior.
The above change will cause lrbp->abort_initiated_by_eh to be set not
only if the UFS error handler decides to abort a command but also if
the
SCSI core decides to abort a command. I think this is wrong.
Sorry, I might have missed something, but I didn't see
scsi abort (ufshcd_abort) calling ufshcd_set_eh_in_progress.
So, during a SCSI abort, ufshcd_eh_in_progress(hba)
should return false and not set this flag, right?
I think you are right so please ignore my comment above.
Additionally, SCSI abort (ufshcd_abort) will have different
return values for MCQ mode and DBR mode when the device
does not respond with a response.
MCQ mode will receivce OCS_ABORTED (nullify)
case OCS_ABORTED:
result |= DID_ABORT << 16;
break;
No. ufshcd_abort() submits an abort TMF and the OCS status is not
modified if the abort TMF succeeds.
But DBR mode, OCS won't change, it is 0x0F
case OCS_INVALID_COMMAND_STATUS:
result |= DID_REQUEUE << 16;
break;
In this case, should we also return DID_ABORT for DBR mode?
The above code comes from ufshcd_transfer_rsp_status(), isn't it?
ufshcd_transfer_rsp_status() should not be called if the SCSI core
aborts a SCSI command (ufshcd_abort()). It is not allowed to call
scsi_done() from a SCSI abort handler like ufshcd_abort(). SCSI
abort handlers must return SUCCESS, FAILED or FAST_IO_FAIL and let
the SCSI core decide whether to complete or whether to resubmit the
SCSI command.
Thanks,
Bart.
