Hi Greg, On 26/08/2024 14:05, gregkh@xxxxxxxxxxxxxxxxxxx wrote: > > The patch below does not apply to the 5.10-stable tree. > If someone wants it applied there, or to any other stable or longterm > tree, then please email the backport, including the original git commit > id to <stable@xxxxxxxxxxxxxxx>. Thank you for the notification! (...) > ------------------ original commit in Linus's tree ------------------ > > From f448451aa62d54be16acb0034223c17e0d12bc69 Mon Sep 17 00:00:00 2001 > From: "Matthieu Baerts (NGI0)" <matttbe@xxxxxxxxxx> > Date: Mon, 19 Aug 2024 21:45:25 +0200 > Subject: [PATCH] mptcp: pm: remove mptcp_pm_remove_subflow() > > This helper is confusing. It is in pm.c, but it is specific to the > in-kernel PM and it cannot be used by the userspace one. Also, it simply > calls one in-kernel specific function with the PM lock, while the > similar mptcp_pm_remove_addr() helper requires the PM lock. > > What's left is the pr_debug(), which is not that useful, because a > similar one is present in the only function called by this helper: > > mptcp_pm_nl_rm_subflow_received() > > After these modifications, this helper can be marked as 'static', and > the lock can be taken only once in mptcp_pm_flush_addrs_and_subflows(). > > Note that it is not a bug fix, but it will help backporting the > following commits. It was helping with newer versions, but not here in v5.10, because other fixes have not been taken. We don't need this patch then. Cheers, Matt -- Sponsored by the NGI0 Core fund.
