On Fri, Aug 30, 2024 at 04:02:17PM +0300, Heikki Krogerus wrote:
> The Cable PD Revision field in GET_CABLE_PROPERTY was
> introduced in UCSI v2.1, so adding check for that.
>
> The cable properties are also not used anywhere after the
> cable is registered, so removing the cable_prop member
> from struct ucsi_connector while at it.
>
> Fixes: 38ca416597b0 ("usb: typec: ucsi: Register cables based on GET_CABLE_PROPERTY")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
> ---
> drivers/usb/typec/ucsi/ucsi.c | 30 +++++++++++++++---------------
> drivers/usb/typec/ucsi/ucsi.h | 1 -
> 2 files changed, 15 insertions(+), 16 deletions(-)
This doesn't apply to my usb-linus branch at all:
checking file drivers/usb/typec/ucsi/ucsi.c
Hunk #1 succeeded at 965 (offset 54 lines).
Hunk #2 FAILED at 941.
Hunk #3 succeeded at 1203 (offset 52 lines).
1 out of 3 hunks FAILED
checking file drivers/usb/typec/ucsi/ucsi.h
Hunk #1 succeeded at 465 (offset 30 lines).
Can you rebase and resend?
thanks,
greg k-h
