Re: [PATCH] tpm: export tpm2_sessions_init() to fix ibmvtpm building

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 02, 2024 at 09:59:13AM +0800, Kexy Biscuit wrote:
> "tpm: ibmvtpm: Call tpm2_sessions_init() to initialize session support"
> breaks ibmvtpm to be built as a module, since tpm2_sessions_init isn't
> an exported symbol. Proposing the following patch to resolve the issue.
> 
> Also, please disregard for the previous incorrectly formatted email.
> ---
> 
> >From 3e43cfa3466178ec7f4309031647e93565bc70bf Mon Sep 17 00:00:00 2001
> From: Kexy Biscuit <kexybiscuit@xxxxxxx>
> Date: Mon, 2 Sep 2024 08:26:38 +0800
> Subject: [PATCH] tpm: export tpm2_sessions_init() to fix ibmvtpm building
> 
> Commit 08d08e2e9f0a ("tpm: ibmvtpm: Call tpm2_sessions_init() to
> initialize session support") adds call to tpm2_sessions_init() in ibmvtpm,
> which could be built as a module. However, tpm2_sessions_init() wasn't
> exported, causing libmvtpm to fail to build as a module:
> 
> ERROR: modpost: "tpm2_sessions_init" [drivers/char/tpm/tpm_ibmvtpm.ko] undefined!
> 
> Export tpm2_sessions_init() to resolve the issue.
> 
> Cc: stable@xxxxxxxxxxxxxxx # v6.10+

Put the git commit id in a Fixes: tag please?

> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Closes: https://lore.kernel.org/oe-kbuild-all/202408051735.ZJkAPQ3b-lkp@xxxxxxxxx/
> Signed-off-by: Kexy Biscuit <kexybiscuit@xxxxxxx>
> Signed-off-by: Mingcong Bai <jeffbai@xxxxxxx>
> ---
>  drivers/char/tpm/tpm2-sessions.c | 1 +
>  1 file changed, 1 insertion(+)


For some reason this patch is attached, and that will not work.  Please
fix up and resend using 'git send-email' or some such tool so that it
can be applied properly.

thanks,

greg k-h




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux