Hi Jiawen, kernel test robot noticed the following build errors: [auto build test ERROR on net/main] url: https://github.com/intel-lab-lkp/linux/commits/Jiawen-Wu/net-txgbe-add-IO-address-in-I2C-platform-device-data/20240826-122232 base: net/main patch link: https://lore.kernel.org/r/20240823030242.3083528-3-jiawenwu%40trustnetic.com patch subject: [PATCH net 2/3] i2c: designware: add device private data passing to lock functions config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20240829/202408291212.L5DejDpz-lkp@xxxxxxxxx/config) compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240829/202408291212.L5DejDpz-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202408291212.L5DejDpz-lkp@xxxxxxxxx/ All errors (new ones prefixed by >>): >> drivers/i2c/busses/i2c-designware-amdpsp.c:246:22: error: too few arguments to function call, single argument 'dev' was not specified 246 | psp_acquire_i2c_bus(); | ~~~~~~~~~~~~~~~~~~~ ^ drivers/i2c/busses/i2c-designware-amdpsp.c:170:12: note: 'psp_acquire_i2c_bus' declared here 170 | static int psp_acquire_i2c_bus(struct dw_i2c_dev *dev) | ^ ~~~~~~~~~~~~~~~~~~~~~~ drivers/i2c/busses/i2c-designware-amdpsp.c:259:22: error: too few arguments to function call, single argument 'dev' was not specified 259 | psp_acquire_i2c_bus(); | ~~~~~~~~~~~~~~~~~~~ ^ drivers/i2c/busses/i2c-designware-amdpsp.c:170:12: note: 'psp_acquire_i2c_bus' declared here 170 | static int psp_acquire_i2c_bus(struct dw_i2c_dev *dev) | ^ ~~~~~~~~~~~~~~~~~~~~~~ drivers/i2c/busses/i2c-designware-amdpsp.c:267:22: error: too few arguments to function call, single argument 'dev' was not specified 267 | psp_release_i2c_bus(); | ~~~~~~~~~~~~~~~~~~~ ^ drivers/i2c/busses/i2c-designware-amdpsp.c:209:13: note: 'psp_release_i2c_bus' declared here 209 | static void psp_release_i2c_bus(struct dw_i2c_dev *dev) | ^ ~~~~~~~~~~~~~~~~~~~~~~ 3 errors generated. vim +/dev +246 drivers/i2c/busses/i2c-designware-amdpsp.c 78d5e9e299e31bc Jan Dabros 2022-02-08 235 78d5e9e299e31bc Jan Dabros 2022-02-08 236 /* 78d5e9e299e31bc Jan Dabros 2022-02-08 237 * Locking methods are based on the default implementation from 78d5e9e299e31bc Jan Dabros 2022-02-08 238 * drivers/i2c/i2c-core-base.c, but with psp acquire and release operations 78d5e9e299e31bc Jan Dabros 2022-02-08 239 * added. With this in place we can ensure that i2c clients on the bus shared 78d5e9e299e31bc Jan Dabros 2022-02-08 240 * with psp are able to lock HW access to the bus for arbitrary number of 78d5e9e299e31bc Jan Dabros 2022-02-08 241 * operations - that is e.g. write-wait-read. 78d5e9e299e31bc Jan Dabros 2022-02-08 242 */ 78d5e9e299e31bc Jan Dabros 2022-02-08 243 static void i2c_adapter_dw_psp_lock_bus(struct i2c_adapter *adapter, 78d5e9e299e31bc Jan Dabros 2022-02-08 244 unsigned int flags) 78d5e9e299e31bc Jan Dabros 2022-02-08 245 { 78d5e9e299e31bc Jan Dabros 2022-02-08 @246 psp_acquire_i2c_bus(); 78d5e9e299e31bc Jan Dabros 2022-02-08 247 rt_mutex_lock_nested(&adapter->bus_lock, i2c_adapter_depth(adapter)); 78d5e9e299e31bc Jan Dabros 2022-02-08 248 } 78d5e9e299e31bc Jan Dabros 2022-02-08 249 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
