On Tue, Aug 27, 2024 at 2:14 PM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > On Tue, Aug 27, 2024 at 11:54:56AM +0900, Namjae Jeon wrote: > > On Mon, Aug 26, 2024 at 8:38 PM <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > > > > > > > > The patch below does not apply to the 5.15-stable tree. > > > If someone wants it applied there, or to any other stable or longterm > > > tree, then please email the backport, including the original git commit > > > id to <stable@xxxxxxxxxxxxxxx>. > > As follows, I have marked stable tag(v6.1+) in patch to apply to 6.1 > > kernel versions or later. > > > > Cc: stable@xxxxxxxxxxxxxxx # v6.1+ > > Yes, but you also say: > > Fixes: eb3e28c1e89b ("smb3: Replace smb2pdu 1-element arrays with flex-arrays") > > Which has been backported to the 5.10.y and 5.15.y kernel trees, so this > is why the FAILED email was triggered. > > > This patch does not need to be applied to 5.15 or 5.10. > > Are you sure? Yes, I have checked it. 5.10 : ksmbd is not here because it was merged into the 5.15 kernel. 5.15: smb client developer backported eb3e28c1e89b commit for only smb client's header. So it doesn't affect the ksmbd server. > If so, why is that the Fixes: tag? checkpatch.pl guide to add Fixes tag if there is a stable tag in the patch. WARNING: The commit message has 'stable@', perhaps it also needs a 'Fixes:' tag? In this case, I should not add fixes: tag...? I didn't know that. Thanks. > > thanks, > > greg k-h