On Wed, Aug 21, 2024 at 09:10:42PM GMT, Ma Ke wrote:
> of_device_get_match_data() can return NULL if of_match_device failed, and
> the pointer 'data' was dereferenced without checking against NULL. Add
> checking of pointer 'data' in qcom_ipq806x_usb_phy_probe().
How do you create the platform_device such that this happens?
Regards,
Bjorn
>
> Cc: stable@xxxxxxxxxxxxxxx
> Fixes: ef19b117b834 ("phy: qualcomm: add qcom ipq806x dwc usb phy driver")
> Signed-off-by: Ma Ke <make24@xxxxxxxxxxx>
> ---
> drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c b/drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c
> index 06392ed7c91b..9b9fd9c1b1f7 100644
> --- a/drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c
> +++ b/drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c
> @@ -492,6 +492,8 @@ static int qcom_ipq806x_usb_phy_probe(struct platform_device *pdev)
> return -ENOMEM;
>
> data = of_device_get_match_data(&pdev->dev);
> + if (!data)
> + return -ENODEV;
>
> phy_dwc3->dev = &pdev->dev;
>
> --
> 2.25.1
>
>
