Re: [PATCH 5.15 085/484] media: dvb-usb: Fix unexpected infinite loop in dvb_usb_read_remote_control()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Em Thu, 15 Aug 2024 16:51:03 +0200
Hans Verkuil <hverkuil-cisco@xxxxxxxxx> escreveu:

> On 15/08/2024 16:20, Greg Kroah-Hartman wrote:
> > On Thu, Aug 15, 2024 at 03:10:39PM +0100, Sean Young wrote:  
> >> On Thu, Aug 15, 2024 at 03:19:03PM +0200, Greg Kroah-Hartman wrote:  
> >>> 5.15-stable review patch.  If anyone has any objections, please let me know.
> >>>
> >>> ------------------
> >>>
> >>> From: Zheng Yejian <zhengyejian1@xxxxxxxxxx>
> >>>
> >>> [ Upstream commit 2052138b7da52ad5ccaf74f736d00f39a1c9198c ]
> >>>
> >>> Infinite log printing occurs during fuzz test:
> >>>
> >>>   rc rc1: DViCO FusionHDTV DVB-T USB (LGZ201) as ...
> >>>   ...
> >>>   dvb-usb: schedule remote query interval to 100 msecs.
> >>>   dvb-usb: DViCO FusionHDTV DVB-T USB (LGZ201) successfully initialized ...
> >>>   dvb-usb: bulk message failed: -22 (1/0)
> >>>   dvb-usb: bulk message failed: -22 (1/0)
> >>>   dvb-usb: bulk message failed: -22 (1/0)
> >>>   ...
> >>>   dvb-usb: bulk message failed: -22 (1/0)
> >>>
> >>> Looking into the codes, there is a loop in dvb_usb_read_remote_control(),
> >>> that is in rc_core_dvb_usb_remote_init() create a work that will call
> >>> dvb_usb_read_remote_control(), and this work will reschedule itself at
> >>> 'rc_interval' intervals to recursively call dvb_usb_read_remote_control(),
> >>> see following code snippet:  
> >>
> >> This commit causes problems and has been reverted upstream.
> >>
> >> https://git.linuxtv.org/media_stage.git/commit/?h=fixes&id=0c84bde4f37ba27d50e4c70ecacd33fe4a57030d
> >>
> >> Please don't apply.  
> > 
> > When will that land in Linus's tree?  Currently this commit is already
> > in released 6.1, 6.6, and 6.10 kernels :(  
> 
> I asked Mauro to make a PR asap. Hopefully for the next rc.

PR just sent:
	https://lore.kernel.org/linux-media/20240815170235.0ab77b44@xxxxxxx/T/#u

Regards,
Mauro


Thanks,
Mauro




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux