On Wed, Aug 14, 2024, Krzysztof Kozlowski wrote:
> Depopulate device in probe error paths to fix leak of children
> resources.
>
> Fixes: 53b5ff83d893 ("usb: dwc3: xilinx: improve error handling for PM APIs")
> Cc: <stable@xxxxxxxxxxxxxxx>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> ---
> drivers/usb/dwc3/dwc3-xilinx.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/dwc3/dwc3-xilinx.c b/drivers/usb/dwc3/dwc3-xilinx.c
> index bb4d894c16e9..b7613a106da6 100644
> --- a/drivers/usb/dwc3/dwc3-xilinx.c
> +++ b/drivers/usb/dwc3/dwc3-xilinx.c
> @@ -330,6 +330,7 @@ static int dwc3_xlnx_probe(struct platform_device *pdev)
> return pm_runtime_resume_and_get(dev);
If pm_runtime_resume_and_get() fails, then probe will fail. We should
probably cleanup in that case too.
BR,
Thinh
>
> err_pm_set_suspended:
> + of_platform_depopulate(dev);
> pm_runtime_set_suspended(dev);
>
> err_clk_put:
> --
> 2.43.0
>
