On 8/14/2024 12:33 PM, Mark Brown wrote:
On Wed, Aug 14, 2024 at 03:00:53AM +0300, Vitaly Chikunov wrote:
On Tue, Aug 13, 2024 at 04:42:04PM +0200, Amadeusz Sławiński wrote:
Should this be cherry-pick of both (they should apply cleanly):
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/sound/soc/soc-topology.c?id=e0e7bc2cbee93778c4ad7d9a792d425ffb5af6f7
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/sound/soc/soc-topology.c?id=0298f51652be47b79780833e0b63194e1231fa34
or just the second one adjusted to apply for stable trees?
I think having commit with memory corruption fix is more important to
stable kernels than not having the code cleanup commit. So, I would
suggest stable policy to be changed a bit, and minor commits like this
code cleanup, be allowed in stable if they are dependence of bug fixing
commits.
Additionally, these neutral commits just make stable trees become closer
to mainline trees (which allows more bug fix commits to be applied
cleanly).
The reason I nacked the cleanup commit was just that there was no
indication that it was a dependency or anything, it just looked like
standard stuff with not reviewing bot output.
I've send both patches for stable in
https://lore.kernel.org/linux-sound/20240814140657.2369433-1-amadeuszx.slawinski@xxxxxxxxxxxxxxx/T/#t
