On Fri, Jul 26, 2024 at 12:23:02PM +0200, Greg Kroah-Hartman wrote: > On Fri, Jul 26, 2024 at 09:53:18AM +0000, Jari Ruusu wrote: > > On Friday, July 26th, 2024 at 11:52, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > > Also the "Fixes:" tag is not in the correct format, please fix that up > > > at the very least. > > > > Some older systems still compile kernels with old gcc version. > > These warnings and errors show up when compiling with gcc 4.9.2 > > > > error: "__GCC4_has_attribute___uninitialized__" is not defined [-Werror=undef] > > > > Following patch fixes this. Upstream won't need this because > > newer kernels are not compilable with gcc 4.9. > > > > Subject: gcc-4.9 warning/error fix for 5.10.223-rc1 > > Fixes: fd7eea27a3ae ("Compiler Attributes: Add __uninitialized macro") > > Signed-off-by: Jari Ruusu <jariruusu@xxxxxxxxxxxxxx> > > > > --- ./include/linux/compiler_attributes.h.OLD > > +++ ./include/linux/compiler_attributes.h > > @@ -37,6 +37,7 @@ > > # define __GCC4_has_attribute___nonstring__ 0 > > # define __GCC4_has_attribute___no_sanitize_address__ (__GNUC_MINOR__ >= 8) > > # define __GCC4_has_attribute___no_sanitize_undefined__ (__GNUC_MINOR__ >= 9) > > +# define __GCC4_has_attribute___uninitialized__ 0 > > # define __GCC4_has_attribute___fallthrough__ 0 > > # define __GCC4_has_attribute___warning__ 1 > > #endif > > > > -- > > Jari Ruusu 4096R/8132F189 12D6 4C3A DCDA 0AA4 27BD ACDF F073 3C80 8132 F189 > > > > Better, thanks! I'll touch this up by hand and apply it to the relevant > branches (not just this one needs it), for the next round of stable > releases. Now queued up. greg k-h