This is a note to let you know that I've just added the patch titled pinctrl: lantiq: remove bogus of_gpio_chip_add to the 3.18-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: pinctrl-lantiq-remove-bogus-of_gpio_chip_add.patch and it can be found in the queue-3.18 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable@xxxxxxxxxxxxxxx> know about it. >From 41f632fe177bc4822c2e8236fe7c291e6e9eb6f8 Mon Sep 17 00:00:00 2001 From: Johan Hovold <johan@xxxxxxxxxx> Date: Mon, 12 Jan 2015 17:20:51 +0100 Subject: pinctrl: lantiq: remove bogus of_gpio_chip_add From: Johan Hovold <johan@xxxxxxxxxx> commit 41f632fe177bc4822c2e8236fe7c291e6e9eb6f8 upstream. Remove bogus call to of_gpiochip_add (and of_gpio_chip remove in error path) which is also called when adding the gpio chip. This prevents adding the same pinctrl range twice. Fixes: 3f8c50c9b110 ("OF: pinctrl: MIPS: lantiq: implement lantiq/xway pinctrl support") Signed-off-by: Johan Hovold <johan@xxxxxxxxxx> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> --- drivers/pinctrl/pinctrl-xway.c | 2 -- 1 file changed, 2 deletions(-) --- a/drivers/pinctrl/pinctrl-xway.c +++ b/drivers/pinctrl/pinctrl-xway.c @@ -798,10 +798,8 @@ static int pinmux_xway_probe(struct plat /* load the gpio chip */ xway_chip.dev = &pdev->dev; - of_gpiochip_add(&xway_chip); ret = gpiochip_add(&xway_chip); if (ret) { - of_gpiochip_remove(&xway_chip); dev_err(&pdev->dev, "Failed to register gpio chip\n"); return ret; } Patches currently in stable-queue which might be from johan@xxxxxxxxxx are queue-3.18/gpio-fix-memory-and-reference-leaks-in-gpiochip_add-error-path.patch queue-3.18/pinctrl-lantiq-remove-bogus-of_gpio_chip_add.patch queue-3.18/gpio-sysfs-fix-gpio-device-attribute-leak.patch queue-3.18/gpio-fix-memory-leak-and-sleep-while-atomic.patch queue-3.18/gpio-sysfs-fix-gpio-chip-device-attribute-leak.patch queue-3.18/gpio-fix-sleep-while-atomic-in-gpiochip_remove.patch queue-3.18/leds-netxbig-fix-oops-at-probe-time.patch -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html