On Wed, Jul 17, 2024 at 01:36:08PM +0300, Jarkko Sakkinen wrote: > On Fri Jul 5, 2024 at 10:45 AM EEST, Dmitrii Kuvaiskii wrote: > > SGX_ENCL_PAGE_BEING_RECLAIMED flag is set when the enclave page is being > > reclaimed (moved to the backing store). This flag however has two > > logical meanings: > ~~~~~~~~ > side-effects Could you clarify the required action here? Do you expect me to replace "This flag however has two logical meanings" with "This flag however has two logical side-effects"? The suggested word doesn't seem to apply nicely to this case. In my text, I have the following two sentences: "Don't attempt to load the enclave page" and "Don't attempt to remove the PCMD page ...". I don't think it's proper English to say that "Don't attempt ..." is a side effect. Or do you want me to also modify the two sentences in the list? By the way, this text is a rephrasing of Dave Hansen's comment: https://lore.kernel.org/all/1d405428-3847-4862-b146-dd57711c881e@xxxxxxxxx/ > > To reflect these two meanings, split SGX_ENCL_PAGE_BEING_RECLAIMED into > > I don't care about meanings. Only who does and what. Could you clarify the required action here? What would be a better rephrasing? Aren't we supposed to clarify the rationale behind the code changes in the commit message? -- Dmitrii Kuvaiskii
