On Tue, Jul 30, 2024 at 6:01 PM David Howells <dhowells@xxxxxxxxxx> wrote: > Can you try this patch instead of either of yours? I booted it on one of the servers, and no problem so far. All tests complete successfully, even the one with copy_file_range that crashed with my patch. I'll let you know when problems occur later, but until then, I agree with merging your revert instead of my patches. If I understand this correctly, my other problem (the folio_attach_private conflict between netfs and ceph) I posted in https://lore.kernel.org/ceph-devel/CAKPOu+8q_1rCnQndOj3KAitNY2scPQFuSS-AxeGru02nP9ZO0w@xxxxxxxxxxxxxx/ was caused by my (bad) patch after all, wasn't it? > For the moment, ceph has to continue using PG_private_2. It doesn't use > netfs_writepages(). I have mostly complete patches to fix that, but they got > popped onto the back burner for a bit. When you're done with those patches, Cc me on those if you want me to help test them. Max
