On 01/19/2015 01:25 PM, Theodore Ts'o wrote:
> On Mon, Jan 19, 2015 at 01:00:03PM -0500, Peter Hurley wrote:
>>>> --- a/drivers/tty/pty.c
>>>> +++ b/drivers/tty/pty.c
>>>> @@ -210,6 +210,9 @@ static int pty_signal(struct tty_struct *tty, int sig)
>>>> {
>>>> struct pid *pgrp;
>>>>
>>>> + if (sig != SIGINT || sig != SIGQUIT || sig != SIGTSTP)
>>>> + return -EINVAL;
>>>
>>> This patch is clearly wrong, should be && not || in the test.
>>
>> Hahaha, whoops.
>
> I think we should also allow SIGWINCH;
Changing the terminal window size is already handled on the pty master
side with TIOCGWINSZ/TIOCSWINSZ ioctls which will send SIGWINCH for the
pty slave process group.
> I'm not sure whether any of the
> line mode emulation code would want SIGTTIN or SIGTTOU, but if we're
> allowing SIGTSTP, there shouldn't be any harm in allowing SIGTTOU and
> SIGTTIN.
While offhand I don't see any harm in that, I actually want to remove this
ioctl completely. It was added in 2010 specifically to support
RFC 1116/LINEMODE, and never picked up by userspace. Even if LINEMODE
support continues in Linux, it may get a userspace interface makeover.
Regards,
Peter Hurley
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html