On Sat, Jan 17, 2015 at 01:59:42PM +0300, Sergei Shtylyov wrote:
> > for (i = 0, tag = ap->last_tag + 1; i < max_queue; i++, tag++) {
> >- tag = tag < max_queue ? tag : 0;
> >+ if (ap->flags & ATA_FLAG_LOWTAG)
> >+ tag = i;
> >+ else
> >+ tag = tag < max_queue ? tag : 0;
>
> Ugh, this is clear abuse of the ?: operator... Why not simply:
>
> else if (tag >= max_queue)
> tag = 0;
Why is that a clear abuse? Seems like a pretty typical use to me.
Thanks.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html