On 7/30/24 11:29, Krzysztof Kozlowski wrote: > On 30/07/2024 11:28, Pierre-Louis Bossart wrote: >>> >>>> >>>> So if ports can be either source or sink, I am not sure how the >>>> properties could be shared with a single array? >>> >>> Because I could, just easier to code. :) Are you saying the code is not >>> correct? If I understand the concept of source/sink dpn port mask, it >>> should be correct. I have some array with source and sink ports. I pass >>> it to Soundwire with a mask saying which ports are source and which are >>> sink. >>> >>>> >>>> Those two lines aren't clear to me at all: >>>> >>>> pdev->prop.sink_dpn_prop = wsa884x_sink_dpn_prop; >>>> pdev->prop.src_dpn_prop = wsa884x_sink_dpn_prop; >>> >>> I could do: s/wsa884x_sink_dpn_prop/wsa884x_dpn_prop/ and expect the >>> code to be correct. >> >> Ah I think I see what you are trying to do, you have a single dpn_prop >> array but each entry is valid for either sink or source depending on the >> sink / source_mask which don't overlap. >> >> Did I get this right? > > Yes, correct. Sounds good, thanks for the explanations. Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>
