Hi Krzysztof,
On Mon, Jul 29, 2024 at 04:09:39PM +0200, Krzysztof Kozlowski wrote:
> On 29/07/2024 13:04, Umang Jain wrote:
> > Rectify the logical value of reset-gpio so that it is set to
> > 0 (disabled) during power-on and to 1 (enabled) during power-off.
> >
> > Meanwhile at it, set the reset-gpio to GPIO_OUT_HIGH at initialization
> > time to make sure it starts off in reset.
> >
> > Fixes: 45d19b5fb9ae ("media: i2c: Add imx335 camera sensor driver")
> > Signed-off-by: Umang Jain <umang.jain@xxxxxxxxxxxxxxxx>
> > ---
> > drivers/media/i2c/imx335.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
>
> This will break all the users, so no. At least not without mentioning
> ABI break and some sort of investigating how customers or users are
> affected.
I know the original authors aren't using the driver anymore and it took
quite a bit of time until others started to contribute to it so I suspect
the driver hasn't been in use for that long. There are no instances of the
device in the in-kernel DTS either.
Any DTS author should have also noticed the issue but of course there's a
risk someone could have just changed the polarity and not bothered to chech
what it was supposed to be.
I agree the commit message should be more vocal about the effects on
existing DTS.
--
Kind regards,
Sakari Ailus
