Re: [PATCH 5.15 70/87] minmax: relax check to allow comparison between unsigned arguments and signed constants

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 26 Jul 2024 07:21:30 +0200 Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:

> On Thu, Jul 25, 2024 at 09:58:51AM -0700, Linus Torvalds wrote:
> > On Thu, 25 Jul 2024 at 07:55, Greg Kroah-Hartman
> > <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> > >
> > > 5.15-stable review patch.  If anyone has any objections, please let me know.
> > 
> > I assume the min/max patches had some reason to be backported that is
> > probably mentioned somewhere in the forest of patches, but I missed
> > it.
> 
> It wasn't specifically called out here, but yes, they were needed for
> the DAEMON fix.  And they will be needed in the future probably as well
> because we have run into this problem many times when backporting
> patches (i.e. the backport throws tons of warnings because the min/max
> changes are not there.)

For others' information, the original backporting request including the detail
is available at https://lore.kernel.org/20240716183333.138498-1-sj@xxxxxxxxxx

Also, s/DAEMON/DAMON/ ;)

> 
> Same for 6.1.y, which is why they are there too.
> 
> > It's ok, but people are literally talking about this set of patches
> > causing a big slowdown in building the kernel, with some files going
> > from less than a second to build to being 15+ seconds because of the
> > preprocessor expansion they can cause.
> 
> I saw that hopefully if that gets resolved in your tree we can backport
> the needed changes here tool.

I agree.


Thanks,
SJ

> 
> thanks,
> 
> greg k-h




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux