On Thu, Jul 25, 2024 at 11:23:43AM +0530, Siddharth Vadapalli wrote: > On Wed, Jul 24, 2024 at 11:23:04AM -0500, Bjorn Helgaas wrote: > > Subject should say something about why this change is needed, not just > > translate the C code to English. > > My intent was to summarize the change to make it easy for anyone to find > out what's being done. The commit message below explains in detail as to > why they are set to NULL. As an alternative, I could change the $subject > to: > PCI: j721e: Disable INTx mapping and swizzling > where the "Disable" is equivalent to NULL. Kindly let me know if this is > acceptable or needs to be improved further. Sounds fine to me.