On Thu, Jul 11, 2024 at 12:56:44PM +0200, Frank Scheiner wrote: > Dear Greg, dear Sasha, > > I noticed a build failure for linux-5.10.y for ia64 ([1]) (sorry, > actually since 5.10.221-rc1, but I didn't notice that build failure > before yesterday :-/ and as the review window for 5.10.222-rc1 is not > yet open, I thought I send it now as response to the last review window > announcement for 5.10.221-rc2): > > https://github.com/linux-ia64/linux-stable-rc/actions/runs/9771252437/job/26974019958#step:8:3524: > ``` > [...] > CC [M] drivers/pps/pps.o > drivers/firmware/efi/memmap.c:16:10: fatal error: asm/efi.h: No such > file or directory > 16 | #include <asm/efi.h> > | ^~~~~~~~~~~ > compilation terminated. > [...] > ``` > > [1]: > https://github.com/linux-ia64/linux-stable-rc/actions/runs/9771252437#summary-26974019958 > > This is related to the recent addition of this change set: > > efi: memmap: Move manipulation routines into x86 arch tree > > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?h=linux-5.10.y&id=31e0721aeabde29371f624f56ce2f403508527a5 > > ...to linux-5.10.y. For ia64 this change set on its own seems incomplete > as it requires a header not available for ia64 w/o additional changes. > > Adding: > > efi: ia64: move IA64-only declarations to new asm/efi.h header > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=8ff059b8531f3b98e14f0461859fc7cdd95823e4 > > ...or from here (according to GitHub this is in linux-stable(-rc) > starting with linux-5.12.y): > > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=8ff059b8531f3b98e14f0461859fc7cdd95823e4 > > fixes it for me with 5.10.222-rc1, see for example [2]. > > [2]: > https://github.com/linux-ia64/linux-stable-rc/actions/runs/9871144965#summary-27258970494 I'm confused, which commit should we add, or should we just revert what we have now? And I thought that ia64 was dead? thanks, greg k-h
