Re: [PATCH 6.1 009/102] irqchip/gic-v3-its: Remove BUG_ON in its_vpe_irq_domain_alloc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 09, 2024 at 08:05:14PM +0800, Zenghui Yu wrote:
> On 2024/7/9 19:09, Greg Kroah-Hartman wrote:
> > 6.1-stable review patch.  If anyone has any objections, please let me know.
> > 
> > ------------------
> > 
> > From: Guanrui Huang <guanrui.huang@xxxxxxxxxxxxxxxxx>
> > 
> > [ Upstream commit 382d2ffe86efb1e2fa803d2cf17e5bfc34e574f3 ]
> > 
> > This BUG_ON() is useless, because the same effect will be obtained
> > by letting the code run its course and vm being dereferenced,
> > triggering an exception.
> > 
> > So just remove this check.
> > 
> > Signed-off-by: Guanrui Huang <guanrui.huang@xxxxxxxxxxxxxxxxx>
> > Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> > Reviewed-by: Zenghui Yu <yuzenghui@xxxxxxxxxx>
> > Acked-by: Marc Zyngier <maz@xxxxxxxxxx>
> > Link: https://lore.kernel.org/r/20240418061053.96803-3-guanrui.huang@xxxxxxxxxxxxxxxxx
> > Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
> 
> I don't think this should be backported to stable. It doesn't fix
> anything but only remove a useless BUG_ON().

Thanks for the review, now dropped from everywhere.

greg k-h




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux