Re: [PATCH iwl-net v1 1/4] igc: Fix qbv_config_change_errors logics

["Abdul Rahim, Faizal" <faizal.abdul.rahim@xxxxxxxxxxxxxxx>]

> > diff --git a/drivers/net/ethernet/intel/igc/igc_tsn.c b/drivers/net/ethernet/intel/igc/igc_tsn.c
> > index 22cefb1eeedf..02dd41aff634 100644
> > --- a/drivers/net/ethernet/intel/igc/igc_tsn.c
> > +++ b/drivers/net/ethernet/intel/igc/igc_tsn.c
> > @@ -78,6 +78,17 @@ void igc_tsn_adjust_txtime_offset(struct igc_adapter *adapter)
> >   	wr32(IGC_GTXOFFSET, txoffset);
> >   }
> >   
> > +bool igc_tsn_is_taprio_activated_by_user(struct igc_adapter *adapter)
> > +{
> > +	struct igc_hw *hw = &adapter->hw;
> > +
> > +	if ((rd32(IGC_BASET_H) || rd32(IGC_BASET_L)) &&
> > +	    adapter->taprio_offload_enable)
> > +		return true;
> > +	else
> > +		return false;
>
> As per my response to patch 2/4, I think something like this is a bit
> nicer:
>
> (Completely untested!)
>
> 	return (rd32(IGC_BASET_H) || rd32(IGC_BASET_L)) &&
> 		adapter->taprio_offload_enable;

Will update, thanks.