On Tue, Jul 02, 2024 at 12:09:25AM -0400, Faizal Rahim wrote: > Removing qbv_count which is now obsolete after these 2 patches: > "igc: Fix reset adapter logics when tx mode change" > "igc: Fix qbv_config_change_errors logics" > > The variable qbv_count serves to indicate whether Taprio is active or if > the tx mode is in TSN (IGC_TQAVCTRL_TRANSMIT_MODE_TSN). This is due to its > unconditional increment within igc_tsn_enable_offload(), which both runs > Taprio and sets the tx mode to TSN. > > Signed-off-by: Faizal Rahim <faizal.abdul.rahim@xxxxxxxxxxxxxxx> Hi Faizal, This change looks good to me. However, it seems more appropriate as a clean-up for iwl-next once the previous to patches make it there via iwl-net. That notwithstanding, Reviewed-by: Simon Horman <horms@xxxxxxxxxx> ...