On 7/3/24 06:04, Kirill A. Shutemov wrote: >>> -/* TDCS fields. To be used by TDG.VM.WR and TDG.VM.RD module calls */ >>> +/* TDX TD-Scope Metadata. To be used by TDG.VM.WR and TDG.VM.RD */ >>> +#define TDCS_CONFIG_FLAGS 0x1110000300000016 >> 0x9110000300000016 >>> +#define TDCS_TD_CTLS 0x11104800000017 >> 0x9110000300000017 > Setting bit 63 in these field id is regression in new TDX spec and TDX > module. It is going to be fixed in next version. Both versions of field > ids are going to be valid. I kinda never liked the big ol' magic numbers approach here. But could we please introduce some helpers here? Then we'll end up with something like this (if the 0x111 can't be decomposed): #define _TDCS_CMD(c) ((0x1110UL << 48) | (c)) #define TDCS_CONFIG_FLAGS _TDCS_CMD(0x16) #define TDCS_TD_CTLS _TDCS_CMD(0x17) Then when folks change their mind about what should be in the TDX spec, we have one place to go fix it up in addition to making this all more readable.
